Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batchInsert() with associative arrays #769

Merged
merged 23 commits into from
Nov 12, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 4, 2023

Fix issue #61

Related PR yiisoft/db-oracle#242

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #61

Copy link

what-the-diff bot commented Nov 4, 2023

PR Summary

  • Updates to 'CHANGELOG.md' file
    The log of changes that we maintain was updated to capture a certain bug fix that has been put in place. It's just a record of what was mended in a specific section of our code related to handling data.

  • Enhancements to 'AbstractDMLQueryBuilder.php'
    A bunch of alterations were made to this file that helps in constructing queries for our database. Some new variables were introduced and a few processes were optimized for efficient handling of data, particularly for a function called batchInsert().

  • Additions to 'CommandProvider.php'
    This job involves adding several new test cases. These are essentially conditions or checks we put in place to make sure the batchInsert() function can handle various scenarios dealing with data. The idea is that by testing our code in these situations, we can make sure it works as well as possible for all our users.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b92cf1d) 99.05% compared to head (8e91e58) 99.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #769   +/-   ##
=========================================
  Coverage     99.05%   99.05%           
- Complexity     1270     1271    +1     
=========================================
  Files            67       67           
  Lines          3078     3080    +2     
=========================================
+ Hits           3049     3051    +2     
  Misses           29       29           
Files Coverage Δ
src/QueryBuilder/AbstractDMLQueryBuilder.php 97.48% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 4, 2023 07:58
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need line in changelog only.

@vjik vjik merged commit 63f68c0 into yiisoft:master Nov 12, 2023
86 of 87 checks passed
@Tigrov Tigrov deleted the fix_batch_insert_with_associative_arrays branch January 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants